Skip to content

update search paragraph command to match ArduinoJSON latest release #647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

vinay-lanka
Copy link
Contributor

Please check if the PR fulfills these requirements

  • What kind of change does this PR introduce?
    Bug Fix -
    The test_search_paragraph searches for an outdated string as the new version of ArduinoJSON is released 6.15.1
    This changes the sentence making the existing test fail.

  • What is the current behavior?

test_search_paragraph under test_lib.py fails as it returns an empty json

  • What is the new behavior?

The tests now pass as the search term has been updated


See how to contribute

The sentence has been updated for the latest 6.15.1 release
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rsora rsora merged commit c076ad3 into arduino:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants